Replace inferred-spans extension with upstream contrib extension #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # inferred-spans/build.gradle.kts
JonasKunz
force-pushed
the
inferred-spans-upstream
branch
from
a874dbb
to
8aa033c
Compare
# Conflicts: # inferred-spans/README.md # inferred-spans/src/main/java/co/elastic/otel/profiler/InferredSpansAutoConfig.java # inferred-spans/src/test/java/co/elastic/otel/InferredSpansAutoConfigTest.java # licenses/more-licences.md
|
Support for |
|
Waiting on open-telemetry/opentelemetry-java-contrib#1533 to implement full backwards compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174.
Replaces the inferred-spans extension with the contributed upstream one, but maintains a backwards compatibility layer for the
ELASTIC_options because they are used a lot already in demos.This PR is also kind of blocked by elastic/apm-data#321. That change did not make it into
8.15. We'll need that change to ship, otherwise the parent-child overriding won't wokr correctly, because the attributeelastic.is_childwas renamed tois_child.